Re: [PATCH] ALSA: ac97: Switch to dev_pm_ops

On Fri, Aug 07, 2015 at 02:30:05PM +0100, Mark Brown wrote:

On Fri, Aug 07, 2015 at 10:13:48AM +0200, Lars-Peter Clausen wrote:

quoted

On 08/07/2015 12:55 AM, Dmitry Torokhov wrote:

quoted

quoted

Pull this out of #ifdef block and kill entire #else/endif along with
WM97XX_PM_OPS define: SIMPLE_DEV_PM_OPS will result in an empty
structure if CONFIG_PM_SLEEP is not set.

quoted

It will create a struct dev_pm_ops full of NULLs. That's kind of
counterproductive to removing PM related data and functions from the kernel
if PM support is no enabled.

Indeed, a major goal of disabling PM support is to save space.

Then maybe we should adjust dev_pm_ops definition to omit members that
are not used if given state is not supported? We have a lot of drivers
that are not doing silly pointer #define games.

-- 
Dmitry