Re: [PATCH v4 1/6] mfd: fsl imx25 Touchscreen ADC driver
From: Linus Walleij <hidden>
Date: 2015-08-17 09:11:17
Also in:
linux-arm-kernel, linux-devicetree, linux-iio
Possibly related (same subject, not in this thread)
- 2014-07-09 · Re: [PATCH v4 1/6] mfd: fsl imx25 Touchscreen ADC driver · Lee Jones <hidden>
- 2014-06-27 · Re: [PATCH v4 1/6] mfd: fsl imx25 Touchscreen ADC driver · Linus Walleij <hidden>
- 2014-06-24 · [PATCH v4 1/6] mfd: fsl imx25 Touchscreen ADC driver · Denis Carikli <hidden>
- 2014-06-24 · [PATCH v4 1/6] mfd: fsl imx25 Touchscreen ADC driver · Denis Carikli <hidden>
On Fri, Jun 27, 2014 at 11:18 AM, Linus Walleij [off-list ref] wrote:
On Tue, Jun 24, 2014 at 4:46 PM, Denis Carikli [off-list ref] wrote:
quoted
+ irq_set_chip_and_handler(irq, &dummy_irq_chip, + handle_level_irq); + set_irq_flags(irq, IRQF_VALID);This function only exists on ARM. Unless Kconfig ensures this is only available on ARM platforms, use #ifdef CONFIG_ARM set_irq_flags(irq, IRQF_VALID); #else irq_set_noprobe(irq); #endif (Sorry we have no better way of doing it.)
Since I wrote this, there have been cleanups from Rob Herring merged to the kernel to get rid of this oddity. Please check in linux-next how to get this right, see c.f. commit e8d36d5dbb6a6ec4f5222f8775d664ec29d5527d "ARM: kill off set_irq_flags usage" Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html