Thread (3 messages) flat view 3 messages, 2 authors, 2015-08-20

Re: [PATCH v2] drivers/hid: Check result of debugfs_create_dir() and debugfs_create_file()

From: Alexander Kuleshov <hidden>
Date: 2015-08-20 17:39:19
Also in: lkml

Hello Jiri,

On 08-19-15, Jiri Kosina wrote:
On Wed, 19 Aug 2015, Alexander Kuleshov wrote:
quoted
 
-	hid_debug_init();
+	if (hid_debug)
+		hid_debug_init();
How is this change related to the rest of the patch?

It's wrong anyway, because hid_debug is independent of the debugfs HID 
debugging facility. Please see for example the printk() a few lines above 
in this very function, which is emited in case hid_debug is enabled.
hmm, I thought that these things are related. I've remove all hid_debug check
and sent v3 of the patch.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help