Re: [PATCH v1] HID: cp2112: fix I2C_SMBUS_BYTE write

On 7/13/2015 4:20 AM, Jiri Kosina wrote:

On Thu, 9 Jul 2015, Ellen Wang wrote:

quoted

When doing an I2C_SMBUS_BYTE write (one byte write, no address),
the data to be written is in "command" not "data->byte".

This is missing Signoff.

Sorry.  I submitted v2.

How serious is this bug in practice? Is this 4.2 material?

The driver segfaults without the fix, and this is a common operation. 
On the other hand, the cp2112 is an uncommon device.

(I would personally like all the cp2112 fixes to be in 4.1 eventually. 
They are all important functional improvements.)