[PATCH] Input: Use for_each_set_bit where appropriate
From: Anshul Garg <hidden>
Date: 2015-07-08 18:09:24
Subsystem:
input (keyboard, mouse, joystick, touchscreen) drivers, the rest · Maintainers:
Dmitry Torokhov, Linus Torvalds
Possibly related (same subject, not in this thread)
- 2015-07-09 · Re: [PATCH] Input: Use for_each_set_bit where appropriate · Anshul Garg <hidden>
- 2015-07-09 · Re: [PATCH] Input: Use for_each_set_bit where appropriate · Dmitry Torokhov <dmitry.torokhov@gmail.com>
- 2015-07-09 · Re: [PATCH] Input: Use for_each_set_bit where appropriate · Anshul Garg <hidden>
- 2015-07-09 · Re: [PATCH] Input: Use for_each_set_bit where appropriate · Dmitry Torokhov <dmitry.torokhov@gmail.com>
- 2015-07-09 · [PATCH] Input: Use for_each_set_bit where appropriate · Anshul Garg <hidden>
Use for_each_set_bit to check for set bits in bitmap as it is more efficient than checking individual bits. Signed-off-by: Anshul Garg <redacted> --- drivers/input/ff-core.c | 5 ++--- drivers/input/joydev.c | 11 +++++------ 2 files changed, 7 insertions(+), 9 deletions(-)
diff --git a/drivers/input/ff-core.c b/drivers/input/ff-core.c
index 8f4a30fc..c642082 100644
--- a/drivers/input/ff-core.c
+++ b/drivers/input/ff-core.c@@ -343,9 +343,8 @@ int input_ff_create(struct input_dev *dev, unsigned int max_effects) __set_bit(EV_FF, dev->evbit); /* Copy "true" bits into ff device bitmap */ - for (i = 0; i <= FF_MAX; i++) - if (test_bit(i, dev->ffbit)) - __set_bit(i, ff->ffbit); + for_each_set_bit(i, dev->ffbit, FF_CNT) + __set_bit(i, ff->ffbit); /* we can emulate RUMBLE with periodic effects */ if (test_bit(FF_PERIODIC, ff->ffbit))
diff --git a/drivers/input/joydev.c b/drivers/input/joydev.c
index f362883..4686260 100644
--- a/drivers/input/joydev.c
+++ b/drivers/input/joydev.c@@ -798,12 +798,11 @@ static int joydev_connect(struct input_handler *handler, struct input_dev *dev, joydev->handle.handler = handler; joydev->handle.private = joydev; - for (i = 0; i < ABS_CNT; i++) - if (test_bit(i, dev->absbit)) { - joydev->absmap[i] = joydev->nabs; - joydev->abspam[joydev->nabs] = i; - joydev->nabs++; - } + for_each_set_bit(i, dev->absbit, ABS_CNT) { + joydev->absmap[i] = joydev->nabs; + joydev->abspam[joydev->nabs] = i; + joydev->nabs++; + } for (i = BTN_JOYSTICK - BTN_MISC; i < KEY_MAX - BTN_MISC + 1; i++) if (test_bit(i + BTN_MISC, dev->keybit)) {
--
1.7.9.5
---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus