Re: [PATCH] MIPS: Remove most of the custom gpio.h
From: Lars-Peter Clausen <lars@metafoo.de>
Date: 2015-07-23 18:26:04
Also in:
linux-gpio, linux-ide, linux-mips, lkml, netdev
On 07/22/2015 07:33 PM, Alban Bedel wrote:
quoted hunk ↗ jump to hunk
diff --git a/arch/mips/jz4740/gpio.c b/arch/mips/jz4740/gpio.c index 54c80d4..3dc500c 100644 --- a/arch/mips/jz4740/gpio.c +++ b/arch/mips/jz4740/gpio.c@@ -262,18 +262,6 @@ uint32_t jz_gpio_port_get_value(int port, uint32_t mask) } EXPORT_SYMBOL(jz_gpio_port_get_value); -int gpio_to_irq(unsigned gpio) -{ - return JZ4740_IRQ_GPIO(0) + gpio; -} -EXPORT_SYMBOL_GPL(gpio_to_irq);
This need to be hooked up the gpio_to_irq() callback of the gpio_chip struct of this driver rather than completely removing it. Otherwise this functionality will be broken. Similar for other platforms which implement the function. - Lars