RE: [PATCH RFC V1 3/3] devicetree: da9062: Add device tree bindings for DA9062 RTC

On 18 July 2015 00:48, Alexandre Belloni wrote:

On 09/07/2015 at 08:45:54 +0100, S Twiss wrote :

quoted

From: S Twiss <redacted>

Add device tree bindings for the DA9062 RTC driver component

Signed-off-by: Steve Twiss <redacted>

[...]

quoted

+- rtc : This node defines settings required for the Real-Time Clock associated
+  with the DA9062. There are currently no entries in this binding, however
+  compatible = "dlg,da9062-rtc" should be added if a node is created.

[...]

quoted

@@ -55,6 +60,10 @@ Example:
 		interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
 		interrupt-controller;

+		rtc {
+			compatible = "dlg,da9062-rtc";
+		};
+

Are those subnodes even parsed? As the parent node is not compatible
with "simple-bus" or "simple-mfd", I guess not. You driver is probed
from the mfd_cells in da9063-core.c

Hi Alexandre,

If I miss out the compatible line for the RTC in the DTSI for DA9062, or is I alter it
so it does not match the string specified in the DA9063 RTC driver, the DA9063 RTC
driver will not be probed for the DA9062 compatibility.
The RTC compatible = "dlg,da9062-rtc"  is essential in this case.

[...]

Regards,
Stephen