On 17 July 2015 23:51, Dmitry Torokhov wrote:

Hi Steve,
On Tue, Jul 14, 2015 at 02:07:50PM +0100, S Twiss wrote:

quoted

From: S Twiss <redacted>
Add DA9062 OnKey support into the existing DA9063 OnKey driver component by
using generic access tables for common register and bit mask definitions.

The following change will add generic register and bit mask support to the
DA9063 OnKey.

The following alterations have been made to the DA9063 OnKey:

- Addition of a da9063_compatible_onkey_regmap structure to hold all
  generic registers and bitmasks for this type of OnKey component.
- Addition of an struct of_device_id table for DA9063 and DA9062
  defaults
- Refactoring functions to use struct da9063_compatible_onkey accesses
  to generic registers/masks instead of using defines from registers.h
- Re-work of da9063_onkey_probe() to use of_match_node() and
  dev_get_regmap() to provide initialisation of generic registers and
  masks and access to regmap

Signed-off-by: Steve Twiss <redacted>

Looks generally good, just a few comments.

Hi Dmitry,

Thanks for taking the time to review this.

[...]

quoted

diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig
index d4f0a81..42860f9 100644
--- a/drivers/input/misc/Kconfig
+++ b/drivers/input/misc/Kconfig

@@ -612,10 +612,10 @@ config INPUT_DA9055_ONKEY

 config INPUT_DA9063_ONKEY
 	tristate "Dialog DA9063 OnKey"

"Dialog DA9062/63 OnKey" maybe?

Yep.
I can do that.

[...]

quoted

-struct da9063_onkey {
-	struct da9063 *hw;
+struct da9063_compatible_onkey_regmap {

Maybe call it da906x_chip_config?

I will do this.

quoted

+	/* REGS */
+	int onkey_status;
+	int onkey_pwr_signalling;
+	int onkey_fault_log;
+	int onkey_shutdown;
+	/* MASKS */
+	int onkey_nonkey_mask;
+	int onkey_nonkey_lock_mask;
+	int onkey_key_reset_mask;
+	int onkey_shutdown_mask;
+	/* NAMES */
+	char *name;

const char *?

Sure -- I'll change that.

quoted

+};
+
+struct da9063_compatible_onkey {

If you did not rename the structure your diff would be smaller.

Yep. I can rename this back to what it was previously.
[...]

I'll submit a PATCH V2 with those changes.

Regards,
Steve