Thread (32 messages) 32 messages, 5 authors, 2015-11-04

Re: [PATCH 07/11] Input: synaptics-rmi4 - f11: fix bitmap irq check

From: Andrew Duggan <hidden>
Date: 2015-07-02 17:51:29
Also in: lkml

On 06/23/2015 12:17 PM, Benjamin Tissoires wrote:
num_irq_regs is the count of registers of 1 bytes that we use to check
the irqs. bitmap_and() expects the number of bits.

Signed-off-by: Benjamin Tissoires <redacted>
---
Reviewed-by: Andrew Duggan <redacted>
quoted hunk ↗ jump to hunk
  drivers/input/rmi4/rmi_f11.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/input/rmi4/rmi_f11.c b/drivers/input/rmi4/rmi_f11.c
index 99d6181..c3b757b 100644
--- a/drivers/input/rmi4/rmi_f11.c
+++ b/drivers/input/rmi4/rmi_f11.c
@@ -726,12 +726,12 @@ static void rmi_f11_finger_handler(struct f11_data *f11,
  		}
  
  		abs_bits = bitmap_and(f11->result_bits, irq_bits, f11->abs_mask,
-				      num_irq_regs);
+				      num_irq_regs * 8);
  		if (abs_bits)
  			rmi_f11_abs_pos_report(f11, sensor, finger_state, i);
  
  		rel_bits = bitmap_and(f11->result_bits, irq_bits, f11->rel_mask,
-				      num_irq_regs);
+				      num_irq_regs * 8);
  		if (rel_bits)
  			rmi_f11_rel_pos_report(sensor, i);
  	}
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help