Re: [PATCH] input: improve usage of gpiod API
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2015-06-17 00:06:12
On Mon, Jun 15, 2015 at 10:38:47PM +0200, Uwe Kleine-König wrote:
Hello Dmitry, On Wed, Feb 18, 2015 at 11:47:13AM +0100, Uwe Kleine-König wrote:quoted
Since 39b2bbe3d715 (gpio: add flags argument to gpiod_get*() functions) which appeared in v3.17-rc1, the gpiod_get* functions take an additional parameter that allows to specify direction and initial value for output. Simplify drivers accordingly. Note that in the case of the drv260x driver error checking is more strict now because -ENOSYS is reported to the caller now. But this should only be returned if GPIOLIB is disabled which shouldn't happen as the driver depends on GPIOLIB. Signed-off-by: Uwe Kleine-König <redacted> --- drivers/input/keyboard/clps711x-keypad.c | 7 +------ drivers/input/misc/drv260x.c | 13 ++++--------- drivers/input/misc/gpio-beeper.c | 7 +------ 3 files changed, 6 insertions(+), 21 deletions(-)are you willing to take this? I intend to make the flags parameter mandatory for 4.3 and so if this change doesn't make it into 4.2-rc1, would it be ok for you if I send it as part of the series that makes flags required?
Yes, I am sorry, applied now. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html