Thread (10 messages) 10 messages, 3 authors, 2015-06-17

Re: [PATCH v4 1/2] dt: add cap11xx LED documentation

From: Matt Ranostay <hidden>
Date: 2015-06-16 14:31:32
Also in: linux-devicetree, linux-leds

On Tue, Jun 16, 2015 at 12:57 AM, Jacek Anaszewski
[off-list ref] wrote:
On 06/16/2015 04:46 AM, Matt Ranostay wrote:
quoted
Signed-off-by: Matt Ranostay <redacted>
---
  .../devicetree/bindings/input/cap11xx.txt          | 23
++++++++++++++++++++++
  1 file changed, 23 insertions(+)
diff --git a/Documentation/devicetree/bindings/input/cap11xx.txt
b/Documentation/devicetree/bindings/input/cap11xx.txt
index 7d0a300..01bb5b8 100644
--- a/Documentation/devicetree/bindings/input/cap11xx.txt
+++ b/Documentation/devicetree/bindings/input/cap11xx.txt
@@ -38,6 +38,11 @@ Optional properties:
                                defaults. The array must have exactly six
                                entries.

+       linux,led-brightness:   Defines the ON brightness when the
optional LED
+                               functionality is used. Valid values are
1-15.
+                               By default a value of 15 is set.
+
+
  Example:

  i2c_controller {
@@ -55,5 +60,23 @@ i2c_controller {
                                 <105>,         /* KEY_LEFT */
                                 <109>,         /* KEY_PAGEDOWN */
                                 <104>;         /* KEY_PAGEUP */
+
+               linux,led-brightness = <15>;

You are missing here:

#address-cells = <1>;
#size-cells = <0>;

Otherwise you will get warnings during compilation of dtc file.
Will fix in v5.
quoted
+               usr@0 {
+                       label = "cap11xx:green:usr0";
+                       reg = <0>;
+               };
+
+               usr@1 {
+                       label = "cap11xx:green:usr1";
+                       reg = <1>;
+               };
+
+               alive@2 {
+                       label = "cap11xx:green:alive";
+                       reg = <2>;
+                       linux,default_trigger = "heartbeat";
+               };
        };
  }

--
Best Regards,
Jacek Anaszewski
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help