Hi Hn,

On Wed, Jun 10, 2015 at 10:41:26PM +0800, Hn Chen wrote:

Hi, Dmitry, 

Thanks for your suggestion !

quoted

Thank you for making changes, I have some more comments. By the way, have you tried running scripts/checkpatch.pl over your patch? 
It often picks up some common issues.

I did the check before I submit the patch every time. Below is the way what I did, is it lack of some parameters ?
./scripts/checkpatch.pl -f driver/input/touchscreen/wdt87xx_i2c.c
Or do I check the wrong file ?  

I believe --strict option does a few more checks, like having spaces
around operations, argument alignment and so forth.

quoted

Why do you need to disable IRQ here just ti enable it again in probe()?

Just in case to prevent the IRQ triggered and the input device is not ready.
After you remind me to create the input device first and then request irq, 
I think they (disable IRQ in request & enable IRQ in probe) can be just removed from codes.

OK good.

Thanks.

-- 
Dmitry