Thread (3 messages) 3 messages, 3 authors, 2015-06-09

Re: [PATCH] hid: Add secondary vendor id for the marco, USB_DEVICE_ID_MS_TYPE_COVER_3_V2

From: Daniel Martin <hidden>
Date: 2015-06-09 08:39:36
Also in: lkml

Possibly related (same subject, not in this thread)

On 21 May 2015 at 04:40, Alan Wu [off-list ref] wrote:
Hello Jiri,
  I believe the patch may work, but I would rename the IDs.  Obviously
I can't test Surface 3 non-Pro cover, but the difference is likely due
to the following:

This is 0x07dc (I do own)
http://www.microsoftstore.com/store/msusa/en_US/pdp/Surface-Pro-Type-Cover/productID.300193600

This is 0x07de (I do not own)
http://www.microsoftstore.com/store/msusa/en_US/pdp/Surface-3-Type-Cover/productID.314885800

I would rename 0x07dc to USB_DEVICE_ID_MS_TYPE_COVER_PRO_3 (original
submitted patch)
and 0x07de to USB_DEVICE_ID_MS_TYPE_COVER_3 (Nicholas' patch).

I would probably also rename 0x07dd to USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_JP.
I've got another Type Cover 3 (0x07e2 ) here, where I was going to
send a patch for. According to the small picture, it looks like a
0x07de - grey, not that glossy keys.

How should I name the define? Won't it be better to append the model
number to distinguish the Type Covers?
I've got a 0x07dc (model 1644) and 0x07e2 (model 1709).
... USB_DEVICE_ID_MS_TYPE_COVER_3_M1644
... USB_DEVICE_ID_MS_TYPE_COVER_3_M1709

The model number (pretty small) can be found on the connector above
the CE sign on the right.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help