Thread (5 messages) 5 messages, 2 authors, 2015-05-21

Re: [PATCH 1/2] input/joydev: Don't classify the vmmouse as a joystick

From: Thomas Hellstrom <hidden>
Date: 2015-05-21 08:15:09

On 05/21/2015 12:23 AM, Dmitry Torokhov wrote:
Hi Thomas,

On Tue, May 19, 2015 at 04:37:04AM -0700, Thomas Hellstrom wrote:
quoted
Joydev is currently thinking some absolute mice are joystick, and that
messes up games in VMware guests, as the cursor typically gets stuck in
the top left corner.

Try to detect the event signature of a VMmouse input device and back off
for such devices. We're still incorrectly detecting, for example, the
VMware absolute USB mouse as a joystick, but adding an event signature
matching also that device would be considerably more risky, so defer that
to a later merge window.
Right. What events does it report?
I'm attaching an evemu-describe event report. One possibility would be
to relax the mouse button requirement from being strictly
left-right-middle to just include left-right-middle, and also accept
relative mouse wheels.

However note that VMware's absolute usb mouse is disabled (by default)
on Linux because of joydev, and even if joydev is
fixed I doubt that it will be enabled by default again, as long as there
are "buggy" joydevs out there. Still, I see a point in adding signature
matching for it anyway, as users can override the default off setting
and it would also pave the way for upcoming similar devices, as adding
signature matching like this in the last minute tends to be risky...
EV_SYN is set automatically on _every_ input device.
There is also amijoy driver that historically uses
BTN_LEFT/RIGHT/MIDDLE.

Does the version of the patch below still work for you?
Yes, it works just fine. If there's a chance we can have that patch in
4.1GA that would be great.

Thanks,
Thomas

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help