Thread (5 messages) 5 messages, 2 authors, 2015-05-15

RE: [PATCH] HID: hid-plantronics: Update to map volume up/down controls

From: Junge, Terry <hidden>
Date: 2015-05-15 00:59:38

On Mon, May 11, 2015, Kosina, Jiri wrote:

 [ ... snip ... ]
I'd like to defer that decision to you. However the patch you submitted
isn't really consistent; therefore it needs to be modified one way or
another anyway.

Basically the two options I am fine with, are:

- keep the USB-isms there, but put an explicit CONFIG_USB dependency into
  the Kconfig and explain in changelog of the patch why this is a good
  thing to do (like the paragraph you wrote above). If you, as a HW
  vendor, are certain that there will never ever be any device using
  non-USB transport, then this is a viable option (not nice, but I can
  understand the reasons for that)

- fall back to PID-based device identification
I will fall back to using PID to identify multi-HID interface devices.
I will be submitting a v2 patch set tomorrow.

Thanks again for your time,
Terry Junge
Plantronics


________________________________

CONFIDENTIALITY NOTICE: This e-mail transmission, and any documents, files or previous e-mail messages attached to it, may contain information that is confidential and/or legally privileged. If you are not the intended recipient, or a person responsible for delivering it to the intended recipient, please DO NOT disclose the contents to another person, store or copy the information in any medium, or use any of the information contained in or attached to this transmission for any purpose. If you have received this transmission in error, please immediately notify the sender by reply email or at privacy@plantronics.com, and destroy the original transmission and its attachments without reading or saving in any manner.

For further information about Plantronics - the Company, its products, brands, partners, please visit our website www.plantronics.com.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help