On 05/13/2015 06:42 PM, Dmitry Torokhov wrote:

On Wed, May 13, 2015 at 04:53:03PM +0200, Jacek Anaszewski wrote:

quoted

On 05/13/2015 04:14 PM, Dmitry Eremin-Solenikov wrote:

quoted

2015-05-13 13:31 GMT+03:00 Jacek Anaszewski [off-list ref]:

quoted

On 05/12/2015 05:35 PM, Dmitry Eremin-Solenikov wrote:

quoted

2015-05-06 18:05 GMT+03:00 Jacek Anaszewski [off-list ref]:

quoted

On 04/28/2015 01:55 AM, Dmitry Eremin-Solenikov wrote:

quoted

Adapt locomo leds driver to new locomo core setup.

Signed-off-by: Dmitry Eremin-Solenikov <redacted>
---
    drivers/leds/Kconfig       |   1 -
    drivers/leds/leds-locomo.c | 119
+++++++++++++++++++++++----------------------
    2 files changed, 61 insertions(+), 59 deletions(-)

diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
index 966b960..4b4650b 100644
--- a/drivers/leds/Kconfig
+++ b/drivers/leds/Kconfig

@@ -79,7 +79,6 @@ config LEDS_LM3642
    config LEDS_LOCOMO
          tristate "LED Support for Locomo device"
          depends on LEDS_CLASS
-       depends on SHARP_LOCOMO

Why do you remove this dependency?

Because SHARP_LOCOMO is a Kconfig symbol for the old driver. New driver
uses MFD_LOCOMO Kconfig entry. Also the driver now uses generic platform
device and regmap interfaces, so there is no direct dependency on main
LoCoMo driver. And the policy (IIRC) was not to have such dependencies.

Ack. Shouldn't you also need "select REGMAP_MMIO" ?

No. Maybe I should add "select REGMAP" instead.

REGMAP is enabled by default if REGMAP_MMIO is enabled. Having

That is unfortunately not how select works: it does not automatically
select parents for the selected symbol.

Please look at config REGMAP declaration in the file
drivers/base/regmap/Kconfig:

config REGMAP
         default y if (REGMAP_I2C || REGMAP_SPI || REGMAP_SPMI || 
REGMAP_AC97 || REGMAP_MMIO || REGMAP_IRQ)
         select LZO_COMPRESS
         select LZO_DECOMPRESS
         select IRQ_DOMAIN if REGMAP_IRQ
         bool

-- 
Best Regards,
Jacek Anaszewski