Thread (2 messages) 2 messages, 2 authors, 2015-05-26

Re: [PATCH] Input:keyboard:samsung-keypad - Fix for correct return type

From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2015-05-26 20:41:40
Also in: lkml

On Mon, May 25, 2015 at 10:30:04PM +0530, Shailendra Verma wrote:
quoted hunk ↗ jump to hunk
The return type of the function samsung_keypad_report() is bool but we are
returning the unsigned int value.So changing the unsigned int to bool type
and initializing with false.

Signed-off-by: Shailendra Verma <redacted>
---
 drivers/input/keyboard/samsung-keypad.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/keyboard/samsung-keypad.c b/drivers/input/keyboard/samsung-keypad.c
index 6b9fdf6..44b1ba9 100644
--- a/drivers/input/keyboard/samsung-keypad.c
+++ b/drivers/input/keyboard/samsung-keypad.c
@@ -112,7 +112,7 @@ static bool samsung_keypad_report(struct samsung_keypad *keypad,
 	struct input_dev *input_dev = keypad->input_dev;
 	unsigned int changed;
 	unsigned int pressed;
-	unsigned int key_down = 0;
+	bool key_down = false;
No, this causes conversion bool->unsigned int->bool on every iteration
of the loop.

Thanks.

-- 
Dmitry
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help