Re: [PATCH] tty: remove platform_sysrq_reset_seq
From: Arnd Bergmann <arnd@arndb.de>
Date: 2015-05-22 19:59:06
Also in:
linux-arm-kernel, linux-serial, lkml
On Thursday 21 May 2015 11:11:28 Arnd Bergmann wrote:
quoted hunk ↗ jump to hunk
diff --git a/drivers/tty/sysrq.c b/drivers/tty/sysrq.c index 8ba52e56bb8b..9c5395db6a57 100644 --- a/drivers/tty/sysrq.c +++ b/drivers/tty/sysrq.c@@ -55,8 +55,7 @@ static int __read_mostly sysrq_enabled = CONFIG_MAGIC_SYSRQ_DEFAULT_ENABLE; static bool __read_mostly sysrq_always_enabled; -unsigned short platform_sysrq_reset_seq[] __weak = { KEY_RESERVED }; -int sysrq_reset_downtime_ms __weak; +static int sysrq_reset_downtime_ms; static bool sysrq_on(void) {
It turns out that the variable is now potentially unused, and we get a warning when CONFIG_INPUT is disabled. I'll send a fixed v2 of this patch. Arnd