Fwd: [PATCH] hid:Change vendor id for USB_DEVICE_ID_MS_TYPE_COVER_3 to correct id in hid-ids.h
From: Alan Wu <hidden>
Date: 2015-05-11 19:06:40
Also in:
lkml
Hello, The Surface Pro 3 Type Cover that I have from US is 045e:07dc. At the time, there was no Surface 3 to distinguish from. I believe many others also have this code. Alan On Mon, May 11, 2015 at 9:22 AM, nick [off-list ref] wrote:
On 2015-05-11 04:44 AM, Jiri Kosina wrote:quoted
On Fri, 8 May 2015, Nicholas Krause wrote:quoted
This fixes the bug,https://bugzilla.kernel.org/show_bug.cgi?id=97951 related to incorrecting using 0x07dc for the vendor id for USB_DEVICE_ID_MS_TYPE_COVER_3 devices and instead changing in to the correct vendor id of 0x07de.Adding Alan Wu, who originally submitted the USB_DEVICE_ID_MS_TYPE_COVER_3 quirk.quoted
Signed-off-by: Nicholas Krause <redacted> --- drivers/hid/hid-ids.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h index 41f167e..2e51947 100644 --- a/drivers/hid/hid-ids.h +++ b/drivers/hid/hid-ids.h@@ -670,7 +670,7 @@ #define USB_DEVICE_ID_MS_SURFACE_PRO_2 0x0799 #define USB_DEVICE_ID_MS_TOUCH_COVER_2 0x07a7 #define USB_DEVICE_ID_MS_TYPE_COVER_2 0x07a9 -#define USB_DEVICE_ID_MS_TYPE_COVER_3 0x07dc +#define USB_DEVICE_ID_MS_TYPE_COVER_3 0x07de #define USB_DEVICE_ID_MS_TYPE_COVER_3_JP 0x07ddWhy do you think we just don't need both of them (i.e. there are persumably two devices that need this patch).Jiri, This is because I assumed as he didn't state the JP hardware and therefore only one was affected. However I will send in a v2 changing both hardware product's vendor id. Cheers, Nick