Thread (7 messages) 7 messages, 4 authors, 2015-03-27

Re: quirk ALWAYS_POLL needed with an unexpectedly high number of mice

From: Benjamin Tissoires <hidden>
Date: 2015-03-27 13:18:12

On Fri, Mar 27, 2015 at 5:29 AM, Oliver Neukum [off-list ref] wrote:
Hi,

I am getting reports from a customer running an unintentional
stress test for this quirk. I would have to add a dozen mice
in the medium term. Is that desirable?
Should we make the quirk the default? Or add a module parameter
to let the pessimistic users with multiple desktop rodents
select the quirk as default? Or just carry on?
Comments?
usbhid/hid-core.c already sets HID_QUIRK_NOGET for regular mice/keyboards [1].
Maybe adding ALLWAYS_POLL to those would make sense and solve your problem?

BTW I am against having this quirk as the general default because we
rely on the usb autosuspend to shut off the touchscreens when no one
listen to them, and the touchscreens are draining a lot of power.

Cheers,
Benjamin

[1] https://git.kernel.org/cgit/linux/kernel/git/jikos/hid.git/tree/drivers/hid/usbhid/hid-core.c#n988
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help