Re: [PATCH v3 2/5] input: synaptics - change default width value of cr48 sensors
From: Benjamin Tissoires <hidden>
Date: 2015-03-23 20:48:23
Also in:
lkml
On Sun, Mar 22, 2015 at 10:43 AM, Gabriele Mazzotta [off-list ref] wrote:
quoted hunk ↗ jump to hunk
The minimum value these sensors can report is 4, so this should be the value used when W is not reporting the width. Signed-off-by: Gabriele Mazzotta <redacted> --- drivers/input/mouse/synaptics.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/input/mouse/synaptics.c b/drivers/input/mouse/synaptics.c index 133e488..a7a0e73 100644 --- a/drivers/input/mouse/synaptics.c +++ b/drivers/input/mouse/synaptics.c@@ -1018,7 +1018,7 @@ static void synaptics_process_packet(struct psmouse *psmouse) if (hw.z > 0 && hw.x > 1) { num_fingers = 1; - finger_width = 5; + finger_width = 4;
I am not sure about this change. It looks benign, but I don't get how changing the local variable finger_width can change anything in the CR48 processing. Except for this one (which could be dropped IMO), the *rest* of the series is: Reviewed-by: Benjamin Tissoires <redacted> Thanks for pushing this Gabriele. Cheers, Benjamin
if (SYN_CAP_EXTENDED(priv->capabilities)) {
switch (hw.w) {
case 0 ... 1:
--
2.1.4