Re: [PATCH] HID: hid-sony: Prevent LED overrun

On Feb 18, 2015 12:32 AM, [off-list ref] wrote:

quoted

quoted

I think this was a bug in the LED system itself fixed by this commit:

http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/leds/leds.h?id=56d06fdee534124f79b51ff92232373b783cddc2

quoted

quoted

In kernel 3.19 the brightness values are clamped correctly and I can't
replicate your bug.

I guess it's possible, I am running 3.19.0rc5. I'll build 3.19 and see
if it's showing the bug.

Ah, my mistake.  That fix wasn't pulled in until 3.20 so you'll need to
grab the latest working version to try it.

Well I did a 'git pull' and left it building overnight, and only just saw
this email...

A quick test this morning shows that the bug does not occur with the new
build, so it looks like my patch is not required after all (and fixing in
LED subsystem makes far more sense).

I am, however, confused about what I pulled and built. It definately had
the patch (I looked in drivers/leds/leds.h before building) but built as
3.19.... guess I'll just have a confused expression for the rest of the
day.

https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/log/drivers/leds/leds.h

Simon.