Thread (2 messages) 2 messages, 2 authors, 2015-02-28

Re: [PATCH] Input: ALPS - fix memory leak when detection fails

From: Pali Rohár <hidden>
Date: 2015-02-28 11:04:33
Also in: lkml

On Saturday 28 February 2015 00:53:57 Dmitry Torokhov wrote:
quoted hunk ↗ jump to hunk
This fixes memory leak introduced by commit
a09221e83e13e09a33109b9b037484eade901cea

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
 drivers/input/mouse/alps.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/input/mouse/alps.c
b/drivers/input/mouse/alps.c index d28726a..1bd15eb 100644
--- a/drivers/input/mouse/alps.c
+++ b/drivers/input/mouse/alps.c
@@ -2605,8 +2605,10 @@ int alps_detect(struct psmouse
*psmouse, bool set_properties) return -ENOMEM;

 	error = alps_identify(psmouse, priv);
-	if (error)
+	if (error) {
+		kfree(priv);
 		return error;
+	}

 	if (set_properties) {
 		psmouse->vendor = "ALPS";
Acked-by: Pali Rohár <redacted>

-- 
Pali Rohár
pali.rohar@gmail.com

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help