Re: [PATCH 6/7] thinkpad_acpi: More Carbon X1 2014 keys
From: Andy Lutomirski <luto@amacapital.net>
Date: 2015-02-20 19:27:45
Also in:
lkml, platform-driver-x86
On 02/20/2015 06:44 AM, Bastien Nocera wrote:
+ KEY_MICCANCEL_MODE, /* Microphone cancellation */
What's this? We already have KEY_MICMUTE. Is this different? If so, can you improve the comment a bit? The answer may be obvious to anyone who has an awful X1 carbon gen 2 keyboard, but these KEY_XYZ defines should IMO be clear enough that even people without the hardware can figure out what's going on. --Andy