Re: [PATCH 1/2] HID: i2c-hid: The interrupt should be level sensitive
From: Jiri Kosina <hidden>
Date: 2015-02-17 12:24:23
Also in:
lkml
From: Jiri Kosina <hidden>
Date: 2015-02-17 12:24:23
Also in:
lkml
On Thu, 29 Jan 2015, Benjamin Tissoires wrote:
quoted
The Microsoft HID over I2C specification says two things regarding the interrupt: 1) The interrupt should be level sensitive 2) The device keeps the interrupt asserted as long as it has more reports available. We've seen that at least some Atmel and N-Trig panels keep the line low as long as they have something to send. The current version of the driver only detects the first edge but then fails to read rest of the reports (as the line is still asserted). Make the driver follow the specification and configure the HID interrupt to be level sensitive. The Windows HID over I2C driver also seems to do the same. Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com> ---FWIW, this one is Acked-by: Benjamin Tissoires <redacted> looks like we are going to drop 2/2, but this one is still valid.
Applied to for-3.20/upstream-fixes, thanks for your friendly ping in form of Ack :) -- Jiri Kosina SUSE Labs