Re: [patch] Input: cyapa - off by on in cyapa_update_fw_store()
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2015-01-22 16:21:36
Also in:
kernel-janitors
On Thu, Jan 22, 2015 at 10:48:01AM +0300, Dan Carpenter wrote:
If "(count == NAME_MAX)" then we could end up putting the NUL terminator one space beyond the end of the fw_name[] array. Signed-off-by: Dan Carpenter <redacted>
Applied, thank you.
quoted hunk ↗ jump to hunk
diff --git a/drivers/input/mouse/cyapa.c b/drivers/input/mouse/cyapa.c index 64c6128..58f4f6f 100644 --- a/drivers/input/mouse/cyapa.c +++ b/drivers/input/mouse/cyapa.c@@ -1013,7 +1013,7 @@ static ssize_t cyapa_update_fw_store(struct device *dev, char fw_name[NAME_MAX]; int ret, error; - if (count > NAME_MAX) { + if (count >= NAME_MAX) { dev_err(dev, "File name too long\n"); return -EINVAL; }
-- Dmitry