Thread (34 messages) 34 messages, 2 authors, 2015-02-12

Re: [PATCH 0/6] Fixes for ALPS trackstick

From: Pali Rohár <hidden>
Date: 2015-01-15 20:28:44

On Thursday 15 January 2015 20:38:18 Dmitry Torokhov wrote:
On Thu, Jan 15, 2015 at 08:19:59PM +0100, Pali Rohár wrote:
quoted
On Thursday 15 January 2015 19:18:20 Dmitry Torokhov wrote:
quoted
On Thu, Jan 15, 2015 at 11:49:32AM +0100, Pali Rohár wrote:
quoted
On Wednesday 14 January 2015 23:55:48 Dmitry Torokhov 
wrote:
quoted
quoted
quoted
quoted
Hi Pali,

This series try to address the issue you brought
regarding trackstick initialization on Dell Latitudes
in a different way than the patches you proposed.
Basically in this series we move resetting and all
detection in alps_detect() and make sure we keep the
state so alps_init() can reuse it and not perform the
detection all over again. Doing this allows us to set
up device characteristics (name, version, etc)
properly from the get go while still performing reset
only once.

This is untested as I do not have any ALPS devices
anymore so I'd appreciate you giving it a spin.

Thanks!
Hi Dmitry,

on top of which branch/repository should I apply your
patches?
Should be applicable to my 'next' branch (which I just
upreved to 3.19-rc4).

Thanks.
Not working at top of next (0c3e994).

Applying: Input: ALPS - renumber protocol numbers
Applying: Input: ALPS - make Rushmore a separate protocol
error: patch failed: drivers/input/mouse/alps.c:1275
error: drivers/input/mouse/alps.c: patch does not apply
Patch failed at 0002 Input: ALPS - make Rushmore a separate
protocol
Hmm.. I created a new alps branch (based on 3.19-rc4), can you
try it?

Thanks.
Compiled from your new alps branch (with "if (!priv)" fix) and 
modprobing psmouse.ko caused laptop freeze :-( Even sysrq not 
responded. So something is not working...

(My original patch series worked fine on my laptop, so when you 
reused my code it should work)

-- 
Pali Rohár
pali.rohar@gmail.com

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help