Thread (17 messages) 17 messages, 6 authors, 2015-03-04

Re: [PATCH v2 2/4] gpio: add parameter to allow the use named gpios

From: Bryan Wu <hidden>
Date: 2015-01-30 19:13:19
Also in: linux-devicetree, linux-gpio, linux-leds, lkml

On Fri, Jan 30, 2015 at 5:46 AM, Linus Walleij [off-list ref] wrote:
On Wed, Jan 21, 2015 at 10:33 PM, Olliver Schinagl
[off-list ref] wrote:
quoted
From: Olliver Schinagl <redacted>

The gpio binding document says that new code should always use named
gpios. Patch 40b73183 added support to parse a list of gpios from child
nodes, but does not make it possible to use named gpios. This patch adds
the con_id property and implements it is done in gpiolib.c, where the
old-style of using unnamed gpios still works.

Signed-off-by: Olliver Schinagl <redacted>
---
 drivers/gpio/devres.c                     | 18 +++++++++++++++++-
 drivers/input/keyboard/gpio_keys_polled.c |  2 +-
 drivers/leds/leds-gpio.c                  |  2 +-
 include/linux/gpio/consumer.h             |  1 +
Alexandre: does this match your vision of how it should work, i.e. ACK?

Bryan/Dmitry: can you ACK the oneliners in your subsystems?
Sure, please take my Ack
Acked-by: Bryan Wu <redacted>
Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help