Re: [PATCH] input: adxl34x: Add OF match support

Hi Geert,

On Thursday 18 December 2014 14:03:18 Geert Uytterhoeven wrote:

On Thu, Dec 18, 2014 at 1:49 PM, Laurent Pinchart wrote:

quoted

There are three compatible strings defined for the ADXL345 and ADXL346 in
Documentation/devicetree/bindings/i2c/trivial-devices.txt: "adi,adxl345",
"adi,adxl346", "adi,adxl34x". Given that the last one is a fallback for
the first two I don't see a need to add the specific compatible strings to
the driver for now. If a new totally incompatible chip named ADXL347 comes
out we will need a new driver which won't be allowed to use the
"adi,adxl34x" compatible string.

FWIW, I'm the evil person who added the adxl entries to that file...

git-blame had already reported you.

Do you think we should remove that compatible string ?

-- 
Regards,

Laurent Pinchart