Re: [PATCH hisi] Input: i2c_atmel_read() can be static
From: zhangfei <zhangfei.gao@linaro.org>
Date: 2014-12-21 11:30:11
Also in:
lkml
On 12/19/2014 09:56 AM, kbuild test robot wrote:
drivers/input/touchscreen/atmel_mXT224E.c:460:5: sparse: symbol 'i2c_atmel_read' was not declared. Should it be static? drivers/input/touchscreen/atmel_mXT224E.c:496:5: sparse: symbol 'i2c_atmel_write' was not declared. Should it be static? drivers/input/touchscreen/atmel_mXT224E.c:532:5: sparse: symbol 'i2c_atmel_write_byte_data' was not declared. Should it be static? drivers/input/touchscreen/atmel_mXT224E.c:538:10: sparse: symbol 'get_object_address' was not declared. Should it be static? drivers/input/touchscreen/atmel_mXT224E.c:547:9: sparse: symbol 'get_object_size' was not declared. Should it be static? drivers/input/touchscreen/atmel_mXT224E.c:557:9: sparse: symbol 'get_object_size_from_address' was not declared. Should it be static? drivers/input/touchscreen/atmel_mXT224E.c:847:32: sparse: symbol 'atmel_ts_get_pdata' was not declared. Should it be static? Signed-off-by: Fengguang Wu <redacted>
Thanks Fengguang for the patch, will take it. However, the file drivers/input/touchscreen/atmel_mXT224E.c is not used for mainline kernel. Xuwei will remove git://github.com/hisilicon/linux-hisi integration-hilt-linux-linaro. Sorry for the confusion. Thanks