Re: [PATCHv2 3/3] ARM:dts:sunxi:ps2 dt nodes for A10/A20 PS2 controller.

Hi,

Please keep the Cc list.

On Wed, Dec 10, 2014 at 01:39:52AM +0530, Vishnu Patekar wrote:

quoted

quoted

--- a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts
+++ b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts

@@ -112,6 +112,19 @@
                      pinctrl-0 = <&uart0_pins_a>;
                      status = "okay";
              };
+             /* PS2 0 and PS2 1 are disabled by default
+             To enable PS2 0 and PS2 1 uncomment below ps20 and ps21

nodes

quoted

+             Please note that ps20 pins conflict with HDMI on Lime2

Board*/

quoted

+             /*ps20: ps2@0x01c2a000 {
+                     pinctrl-names = "default";
+                     pinctrl-0 = <&ps2_0_pins>;
+                     status = "okay";
+             };
+             ps21: ps2@0x01c2a400 {
+                     pinctrl-names = "default";
+                     pinctrl-0 = <&ps2_1_pins>;
+                     status = "okay";
+             };*/

Hmmm, no, no comments in the DTS.

Especially when it's that trivial to enable.

Okie, I'll just keep ps20 and ps21 nodes commented.

No, the comments themselves were great. But the nodes themselves
shouldn't be there in the first place.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com