On Thursday 13 November 2014 16:29:02 Laxman Dewangan wrote:

On Thursday 13 November 2014 04:17 PM, Arnd Bergmann wrote:

quoted

I notice that Laxman Dewangan initially added the feature as part of
(I assume) work on Tegra, but these days Tegra is DT-only so it can't
actually get used for that any more.

If we have a real usecase, I think we can still take your patch, but
my impression at the moment is that it may be better to instead
remove the feature entirely by reverting d8ee4a1c9052 ("Input:
gpio_keys - add support for interrupt only keys").

Regarding your initial use case of testing interrupt polarity, would
you have been able to do the same thing by looking at the interrupt
count in /proc/interrupts?

Yes, I posted patch for interrupt key on context on key connected to 
PMIC-Onkey.
On PMIC, there is onkey pin input which generates interrupt only when it 
toggles. So if we have key (power key on our platforms) connected to 
this pin then we will only get interrupt from PMIC.
Instead of implementing full interrupt key driver, I added this support 
on existing gpio keys.

So is this code still in place, and do you think it's worthwhile to
have a DT binding for it?

Could the PMIC register a gpio controller instead?

	Arnd