Re: [PATCH v1] Input: elants_i2c: Add Elan touchscreen support

Hi Oliver,

On Thu, Nov 20, 2014 at 11:31:30AM +0100, Oliver Neukum wrote:

quoted

+static int elants_i2c_initialize(struct elants_data *ts)
+{
+       struct i2c_client *client = ts->client;
+       int error, retry_cnt;
+       const u8 hello_packet[] = { 0x55, 0x55, 0x55, 0x55 };
+       const u8 recov_packet[] = { 0x55, 0x55, 0x80, 0x80 };
+       u8 buf[HEADER_SIZE];
+

Strictly speaking you should disable preemption here.

Umm, why?

quoted

+       for (retry_cnt = 0; retry_cnt < MAX_RETRIES; retry_cnt++) {
+               error = elants_i2c_sw_reset(client);
+               if (error) {
+                       /* Continue initializing if it's the last try
*/
+                       if (retry_cnt < MAX_RETRIES - 1)
+                               continue;
+               }

Thanks.

-- 
Dmitry