Thread (15 messages) 15 messages, 4 authors, 2014-11-27

Re: [git pull] Input updates for 3.18-rc4

From: Marcus Overhagen <hidden>
Date: 2014-11-19 19:23:47
Also in: lkml

Hi Dmitry,

luckily I found some time right now. I haven't reverted the original large
patch, but I tested your short patch and it fixes the problem for me.

regards
Marcus

On Wed, Nov 19, 2014 at 7:39 PM, Dmitry Torokhov
[off-list ref] wrote:
quoted hunk ↗ jump to hunk
On Wed, Nov 19, 2014 at 07:20:21PM +0100, Marcus Overhagen wrote:
quoted
Hi,

I will try reverting that, but may need until tomorrow or Friday.

Just now I made a warm reboot from rc3 to rc5 and initially scrolling
behaviour was ok,  but after about a minute it went wrong and I got
this:

[  179.705362] ------------[ cut here ]------------
[  179.705382] WARNING: CPU: 3 PID: 0 at
drivers/input/mouse/elantech.c:433
elantech_report_trackpoint.isra.5+0x199/0x1b0 [psmouse]()
[  179.705385] psmouse serio1: elantech: Unexpected trackpoint message
Or just this for now:
diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c
index 3fcb6b3..294f613 100644
--- a/drivers/input/mouse/elantech.c
+++ b/drivers/input/mouse/elantech.c
@@ -793,7 +793,7 @@ static int elantech_packet_check_v4(struct psmouse *psmouse)
        unsigned char packet_type = packet[3] & 0x03;
        bool sanity_check;

-       if ((packet[3] & 0x0f) == 0x06)
+       if ((packet[3] & 0x0f) == 0x06 && etd->tp_dev)
                return PACKET_TRACKPOINT;

        /*

--
Dmitry
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help