Re: [PATCH] Input: gpio_keys: Make sure wake-up buttons work.
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2014-11-07 23:45:16
Also in:
lkml
Hi Neil, On Sat, Nov 08, 2014 at 10:37:07AM +1100, NeilBrown wrote:
quoted hunk ↗ jump to hunk
If a key is to be used for wake-up, we must not disable the interrupt during suspend. Signed-off-by: NeilBrown <redacted>diff --git a/drivers/input/keyboard/gpio_keys.c b/drivers/input/keyboard/gpio_keys.c index 8c98e97f8e41..0b5e54ae343e 100644 --- a/drivers/input/keyboard/gpio_keys.c +++ b/drivers/input/keyboard/gpio_keys.c@@ -526,6 +526,8 @@ static int gpio_keys_setup_key(struct platform_device *pdev, */ if (!button->can_disable) irqflags |= IRQF_SHARED; + if (button->wakeup) + irqflags |= IRQF_NO_SUSPEND;
No, enable_irq_wake() should be enough. I believe Rafael has fixed that in the core, right?
error = devm_request_any_context_irq(&pdev->dev, bdata->irq, isr, irqflags, desc, bdata);
Thanks. -- Dmitry