Re: [PATCH] usbhid: add another mouse that needs QUIRK_ALWAYS_POLL

On Wed, 1 Oct 2014, Oliver Neukum wrote:

quoted

quoted

--- a/drivers/hid/usbhid/hid-quirks.c
+++ b/drivers/hid/usbhid/hid-quirks.c

@@ -80,6 +80,8 @@ static const struct hid_blacklist {
 	{ USB_VENDOR_ID_PENMOUNT, USB_DEVICE_ID_PENMOUNT_1610, HID_QUIRK_NOGET },
 	{ USB_VENDOR_ID_PENMOUNT, USB_DEVICE_ID_PENMOUNT_1640, HID_QUIRK_NOGET },
 	{ USB_VENDOR_ID_PIXART, USB_DEVICE_ID_PIXART_USB_OPTICAL_MOUSE, HID_QUIRK_ALWAYS_POLL },
+	/* OEM version same strings but different IDs */
+	{ USB_VENDOR_ID_KYE, USB_DEVICE_ID_PIXART_USB_OPTICAL_MOUSE_ID2, HID_QUIRK_ALWAYS_POLL },

I don't like the added comment, it makes the list look ugly (as no other 
device has such a comment). The details are in the git changelog anyway.

Are you fine with me removing the comment before commiting the patch?

If you wish to remove it, please do so. 

Thanks, I removed it and applied.

However, if people then complain that I mixed up vendor IDs, will you 
handle that? ;)

I am pretty good at running git blame and looking into changelogs, no 
worries :)

Thanks,

-- 
Jiri Kosina
SUSE Labs