Thread (2 messages) 2 messages, 2 authors, 2014-10-21

Re: [PATCH v2 3/4] ARM: dts: sun5i: Add lradc node

From: Hans de Goede <hidden>
Date: 2014-10-21 20:29:51
Also in: linux-arm-kernel, linux-devicetree

Possibly related (same subject, not in this thread)

Hi,

On 10/21/2014 06:21 PM, Dmitry Torokhov wrote:
Hi Hans,

On Tue, Oct 21, 2014 at 10:24:49AM +0200, Hans de Goede wrote:
quoted
+			button@98 {
+				label = "Home";
+				linux,code = <KEY_HOME>;
I do not think you really want KEY_HOME (go to the beginning of the
line) here, KEY_HOMEPAGE or similar would suit better.
I can understand where you're coming from, but KEY_HOME is what these
keys typically send under android, and what android expects them to
send...

Not sure if that is a good argument to keep it as KEY_HOME though.

Please let me know which way you want this key to be mapped, and
I'll update it for the next version.

Regards,

Hans
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help