Thread (24 messages) 24 messages, 4 authors, 2014-10-29

Re: [PATCH 00/13] HID: add support of Logitech touchpads and special devices

From: Jiri Kosina <hidden>
Date: 2014-10-29 09:49:13
Also in: lkml

On Tue, 28 Oct 2014, Benjamin Tissoires wrote:
quoted
quoted
I've tested these patches successfully on a Chromebook Pixel with the
following devices:

- T650 touchpad
- TK820 keyboard/touchpad
- Original WTP touchpad

I also tested a touch mouse and as expected it continued to function
as a plain USB mouse. The TK820 was indeed broken into two devices,
with autorepeat enabled for the keyboard only. The other two devices
behaved as expected with no perceived regressions.

In short, from a functionality perspective I'm happy with these
patches. I will let others discuss code structure.
Thank you. Can I use

        Tested-by: Andrew de los Reyes [off-list ref]

once / if I am merging this patchset?
I am pretty sure this is not required too, but I am raising this one
again in Jiri's pile of things to review.
Sorry Jiri, I did not forget about it :)
It absolutely hasn't been forgotten, I've been just a bit busy during past 
weeks.

I am almost done with the review, expect to hear from me in a 1-2 days 
timeframe regarding this series.

Thanks for patience,

-- 
Jiri Kosina
SUSE Labs
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help