On Mon, 2014-10-27 at 11:01 -0700, Dmitry Torokhov wrote:

On Monday, October 27, 2014 10:56:54 AM Joe Perches wrote:

quoted

On Mon, 2014-10-27 at 07:44 -0700, Dmitry Torokhov wrote:

quoted

On Sun, Oct 26, 2014 at 10:24:59PM -0700, Joe Perches wrote:

quoted

Precedence of & and >> is not the same and is not left to right.
shift has higher precedence and should be done after the mask.

Looking at the protocol description the current code is exactly right.
We want to "move" button bits first as in packet type 1 they are in a
different place than in other packets.

I'll take a patch that adds parenthesis around shifts to make clear it
is intended.

I think it's more sensible to do the shift first to a
temporary then direct comparisons.

[]

Unless you have the device I'd rather kept the changes (which are mostly
cosmetic in nature and do not fix any bugs) to a minimum.

I don't have the device.
I think you should do what you think appropriate.

cheers, Joe