On Mon, Oct 06, 2014 at 06:52:51PM -0700, Bjorn Andersson wrote:

On Mon 06 Oct 18:30 PDT 2014, Dmitry Torokhov wrote:

quoted

Hi Bjorn,

Hi,

quoted

On Mon, Oct 06, 2014 at 06:12:00PM -0700, Bjorn Andersson wrote:

quoted

+
+	rc = devm_request_threaded_irq(&pdev->dev, pwrkey->irq,
+				NULL, pm8941_pwrkey_irq,
+				IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING |

Do we need to hard-code IRQ flags like this? I'd rather we respect DT
data.

We could "move" it to DT but I don't think there's any other combination of
these flags would make sense. If you insist I can remove it though.

No, that's fine if you are certain we want to react on both edges always.

Thanks.

-- 
Dmitry