Re: [PATCH v3 1/3] cap11xx: make driver generic for variant support
From: Matt Ranostay <hidden>
Date: 2014-09-29 02:45:10
Also in:
linux-devicetree, lkml
From: Matt Ranostay <hidden>
Date: 2014-09-29 02:45:10
Also in:
linux-devicetree, lkml
On Sat, Sep 27, 2014 at 11:21 AM, Daniel Mack [off-list ref] wrote:
On 09/25/2014 07:24 AM, Matt Ranostay wrote:quoted
cap1106 driver can support much more one device make the driver generic for support of similiar parts. Signed-off-by: Matt Ranostay <redacted> --- .../devicetree/bindings/input/cap1106.txt | 53 ---- .../devicetree/bindings/input/cap11xx.txt | 54 ++++ drivers/input/keyboard/Kconfig | 8 +- drivers/input/keyboard/Makefile | 2 +- drivers/input/keyboard/cap1106.c | 341 --------------------- drivers/input/keyboard/cap11xx.c | 340 ++++++++++++++++++++ 6 files changed, 399 insertions(+), 399 deletions(-)As I've said, such a patch is really a whole lot more readable if you use the -M switch for git format-patch to detect renames.
TIL I learned of new git format-patch option. Will resubmit v4.
Other than that, the series now looks good to me. I can't test it, however, as I don't have access to the hardware anymore.
Yeah I can't confirm it works on cap1106 but there is no reason it wouldn't work. Cap1188 works as expected. Thanks, Matt
Reviewed-by: Daniel Mack [off-list ref] Thanks, Daniel