Re: [PATCH 2/3] cap1106: support for active-high interrupt option
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2014-09-22 05:57:04
Also in:
linux-devicetree, lkml
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2014-09-22 05:57:04
Also in:
linux-devicetree, lkml
On Sun, Sep 21, 2014 at 12:06:30PM +0200, Daniel Mack wrote:
On 09/21/2014 05:01 AM, Matt Ranostay wrote:quoted
Some applications need to use the active-high push-pull interrupt option. This allows it be enabled in the device tree child node. Signed-off-by: Matt Ranostay <redacted> --- drivers/input/keyboard/cap1106.c | 6 ++++++ 1 file changed, 6 insertions(+)diff --git a/drivers/input/keyboard/cap1106.c b/drivers/input/keyboard/cap1106.c index b9c43b5..33e2590 100644 --- a/drivers/input/keyboard/cap1106.c +++ b/drivers/input/keyboard/cap1106.c@@ -234,6 +234,12 @@ static int cap1106_i2c_probe(struct i2c_client *i2c_client, dev_err(dev, "Invalid sensor-gain value %d\n", gain32); } + if (of_property_read_bool(node, "microchip,active-high")) {I think the name of that property should make clear it's only changing the interrupt output driver configuration. What about "microchip,irq-active-high"?
Can we infer the setting from IRQ flags by chance? Thanks. -- Dmitry