Re: [RESEND PATCH 1/7] mfd: cros_ec: Delay for 50ms when we see EC_CMD_REBOOT_EC
From: Lee Jones <hidden>
Date: 2014-08-21 13:37:47
Also in:
linux-i2c, linux-samsung-soc
From: Lee Jones <hidden>
Date: 2014-08-21 13:37:47
Also in:
linux-i2c, linux-samsung-soc
On Wed, 20 Aug 2014, Javier Martinez Canillas wrote:
From: Doug Anderson <dianders@chromium.org> If someone sends a EC_CMD_REBOOT_EC to the EC, the EC will likely be unresponsive for quite a while. Add a delay to the end of the command to prevent random failures of future commands. NOTES: * This could be optimized a bit by simply delaying the next command sent, but EC_CMD_REBOOT_EC is such a rare command that the extra complexity doesn't seem worth it. * This is a bit of an "ugly hack" since the SPI driver is effectively snooping on the communication and making a lot of assumptions. It would be nice to architect in some better solution long term.
Are you planning on doing that?
* This same logic probably needs to be applied to the i2c driver. Signed-off-by: Doug Anderson <dianders@chromium.org> Reviewed-by: Randall Spangler <redacted> Reviewed-by: Vadim Bendebury <redacted> Signed-off-by: Javier Martinez Canillas <redacted> --- drivers/mfd/cros_ec_spi.c | 9 +++++++++ 1 file changed, 9 insertions(+)
I'm willing to accept this as a stand-in. Acked-by: Lee Jones <redacted> -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog