Re: [PATCH] m68k/atari: Remove obsolete keyboard_tasklet scheduling
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2014-08-31 09:16:49
Also in:
lkml
Hi Michael, On Sun, Aug 31, 2014 at 11:07 AM, Michael Schmitz [off-list ref] wrote:
quoted
If CONFIG_VT=n: arch/m68k/atari/built-in.o: In function `atari_keyboard_interrupt': atakeyb.c:(.text+0x1846): undefined reference to `keyboard_tasklet' atakeyb.c:(.text+0x1852): undefined reference to `keyboard_tasklet'Has keyboard_tasklet gone for good, or just been conditionalized on CONFIG_VT?
Conditionalized. It's in drivers/tty/vt/keyboard.c. Note that this was from a randconfig build.
quoted
I think the keyboard_tasklet scheduling is no longer needed, as I believe it's handled by drivers/tty/vt/keyboard.c based on events received from the input subsystem. So just remove it.I'd like to test this on real hardware (though ARAnyM does emulate the keyboard ACIA IIRC - if you had a working keyboard there I should find no different),
Keyboard was still working on ARAnyM.
But AFAICU, the keyboard_tasklet is used for the LED state only.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds