Re: [PATCH V2 2/2] Input: misc: introduce palmas-pwrbutton

From
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date
2014-08-21 17:05:19
Also in
linux-arm-kernel, linux-devicetree, linux-omap, lkml
Reply to
Nishanth Menon, 2014-08-21
Hi Nishanth,

On Thu, Aug 21, 2014 at 11:02:15AM -0500, Nishanth Menon wrote:
quoted hunk ↗ jump to hunk
+
+	ret = input_register_device(input_dev);
+	if (ret) {
+		free_irq(irq, pwron);
You can not use free_irq with devm-managed resources. As I mentioned, since you
need manual unwinding, I'd rather you not use managed resources in the driver
at all.
quoted hunk ↗ jump to hunk
+		cancel_delayed_work_sync(&pwron->input_work);
+		dev_dbg(dev, "Can't register power button: %d\n", ret);
+		return ret;
Thanks.

-- 
Dmitry
Thread (24 messages) 24 messages, 3 authors, last reply 2014-09-12
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help