Re: [PATCH] Input: atmel_mxt_ts - fix a few issues reported by Coverity
From: Stephen Warren <hidden>
Date: 2014-08-12 16:40:56
Also in:
lkml
On 08/12/2014 10:38 AM, Nick Dyer wrote:
On 11/08/14 19:03, Dmitry Torokhov wrote:quoted
This should fix the following issues reported by Coverity: *** CID 1230625: Logically dead code (DEADCODE) /drivers/input/touchscreen/atmel_mxt_ts.c: 1692 in mxt_initialize() *** CID 1230627: Missing break in switch (MISSING_BREAK) /drivers/input/touchscreen/atmel_mxt_ts.c: 1436 in mxt_get_object_table() *** CID 1230629: Out-of-bounds write (OVERRUN) /drivers/input/touchscreen/atmel_mxt_ts.c: 1267 in mxt_update_cfg() *** CID 1230632: Unused pointer value (UNUSED_VALUE) /drivers/input/touchscreen/atmel_mxt_ts.c: 1211 in mxt_update_cfg() Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>I've reviewed these changes and they look correct to me. Apologies that they slipped through, most of it is bad merging on my part I think. Signed-off-by: Nick Dyer <redacted>
Don't you mean Acked-by or Reviewed-by?