Re: [PATCH] HID:hid-logitech: Prevent possibility of infinite loop when using /sys interface
From: Jiri Kosina <hidden>
Date: 2014-08-12 14:30:24
Also in:
lkml
On Wed, 6 Aug 2014, Simon Wood wrote:
If the device data is not accessible for some reason, returning 0 will cause the call to be continuously called again as none of the string has been 'consumed'.
Hi Simon, this patch is missing signoff.
quoted hunk ↗ jump to hunk
--- drivers/hid/hid-lg4ff.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/drivers/hid/hid-lg4ff.c b/drivers/hid/hid-lg4ff.c index cc2bd20..7835717 100644 --- a/drivers/hid/hid-lg4ff.c +++ b/drivers/hid/hid-lg4ff.c@@ -451,13 +451,13 @@ static ssize_t lg4ff_range_store(struct device *dev, struct device_attribute *at drv_data = hid_get_drvdata(hid); if (!drv_data) { hid_err(hid, "Private driver data not found!\n"); - return 0; + return -EINVAL; } entry = drv_data->device_props; if (!entry) { hid_err(hid, "Device properties not found!\n"); - return 0; + return -EINVAL; } if (range == 0)
-- Jiri Kosina SUSE Labs