Re: [PATCH] Input: s3c2410_ts: Move to clk_prepare_enable/clk_disable_unprepare

On 22 July 2014 23:09:14 Dmitry Torokhov wrote:

Hi Vasily,

On Wed, Jul 09, 2014 at 12:13:41PM +0300, Vasily Khoruzhick wrote:

quoted

On 8 July 2014 18:00:49 Dmitry Torokhov wrote:

Hi Dmitry,

quoted

quoted

-	clk_disable(ts.clock);
+	clk_disable_unprepare(ts.clock);

Do we really need to unprepare on suspend? Why simply disabling is not
enough here?

You're right, disabling should be enough here. I'll resend a patch after
testing on a hardware.

I ended up cutting out suspend/resume parts and applying.

Ah, I was about to send v2. I've tested a version with clk_disable/clk_enable 
in suspend/resume parts, and it works OK for me.

Thanks!

Regards,
Vasily

Thanks.