Re: [PATCH v2 07/10] Input - wacom: handle Graphire BT tablets in wacom.ko
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2014-07-24 19:58:33
Also in:
lkml
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2014-07-24 19:58:33
Also in:
lkml
On Thu, Jul 24, 2014 at 03:43:52PM -0400, Benjamin Tissoires wrote:
On Jul 24 2014 or thereabouts, Dmitry Torokhov wrote:quoted
Hi Benjamin, On Thu, Jul 24, 2014 at 02:14:02PM -0400, Benjamin Tissoires wrote:quoted
+ } else if (features->type == GRAPHIRE_BT) { + /* Compute distance between mouse and tablet */ + rw = 44 - (data[6] >> 2); + if (rw < 0) + rw = 0; + else if (rw > 31) + rw = 31;rw = clamp_val(rw, 0, 31); ?could be... I'll do the tests and resubmit later the v3. I'll wait a little in case you have other comments on the other patches :)
How about doing it incrementally - the patch is still sound as far as I am concerned. I will wait a bit for other to chime in with comments or acks before applying this series. -- Dmitry