Thread (6 messages) 6 messages, 5 authors, 2014-07-27

Re: [PATCH v2] iio: exynos-adc: add experimental touchscreen support

From: Arnd Bergmann <hidden>
Date: 2014-07-22 18:34:09
Also in: linux-arm-kernel, linux-iio, linux-samsung-soc, lkml

On Tuesday 22 July 2014 11:09:04 Dmitry Torokhov wrote:
quoted
@@ -565,6 +722,15 @@ static int exynos_adc_probe(struct platform_device *pdev)
      if (info->data->init_hw)
              info->data->init_hw(info);
 
+     /* leave out any TS related code if unreachable */
+     if (IS_BUILTIN(CONFIG_INPUT) ||
+         (IS_MODULE(CONFIG_INPUT) && config_enabled(MODULE)))
This is ugly... We need IS_SUBSYSTEM_AVAILABLE() wrapper for this...

Anyway,

Acked-by: Dmitry Torokhov <redacted>
I actually have a patch to introduce IS_REACHABLE() for this purpose,
but I haven't sent it out for review yet. The main user of this would
be drivers/media, which had the correct logic earlier until someone
tried to "simplify" it by replacing it all with IS_ENABLED()...

	Arnd
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help